[Bug 729512] Review Request: graphite2 - Font rendering capabilities for complex non-Roman writing systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=729512

--- Comment #5 from Martin Krizek <mkrizek at redhat.com> 2011-08-17 08:30:49 EDT ---
During informal review I didn't find any issues, except those stated in the
rpmlint output. I do however have some comments on the spec file:

I think following lines
cp LICENSE $RPM_BUILD_ROOT/usr/share/graphite2

%files
%doc /usr/share/graphite2/LICENSE

should be replaced with just

%files
%doc LICENSE

Also this line:
%doc /usr/share/graphite2/*.cmake

seems incorrect to me. Assuming *.cmake belongs to %doc (which I don't know)
and therefore package can run without those files - is it neccessary to use the
whole path? At least I would replace /usr/share with the macro (and graphite2
for that matter).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.