[Bug 729263] Review Request: rubygem-virt-p2v - Send a machine's storage and metadata to virt-p2v-server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=729263

--- Comment #3 from Richard W.M. Jones <rjones at redhat.com> 2011-08-18 07:22:25 EDT ---
This package is ExclusiveArch: i686 (for perfectly good reasons).
However this means I could not build it on my local machine.  Therefore
all testing was done using the packages built in Koji.

- rpmlint output

No %changelog section in the spec file.

Multiple instances of 'incorrect-fsf-address' in the source.  I will
submit a patch upstream to fix this.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines

%defattr lines are not strictly required, but can be left in for
EPEL compatibility.

BuildRoot is no longer needed, but can be left in for EPEL compat.

+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
  (only on i686)
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
  (because of Koji scratch build)
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ consistent use of macros
+ package must contain code or permissible content
+ large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file

Although this is a "GUI app" it is not a desktop app.  It boots
from an ISO on a separate machine, so no desktop file is required.

+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8

Optional:

n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock
+ the package should build into binary RPMs on all supported architectures
+ review should test the package functions as described
n/a scriptlets should be sane
n/a pkgconfig files should go in -devel
n/a shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin

-------------

The package has a couple of errors which are very simple to fix, so I'll
just go ahead and submit fixes on behalf of the packager.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.