[Bug 729512] Review Request: graphite2 - Font rendering capabilities for complex non-Roman writing systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=729512

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #8 from Martin Gieseking <martin.gieseking at uos.de> 2011-08-19 03:13:50 EDT ---
OK, great. The package looks fine now. Just two (optional) suggestions:

- Move %post and %postun behind the %install section (and before %files). 
  It's just the common location.

- %{_libdir}/libgraphite2.so.2.0.0 is a bit too precise. :) In order to
  simplify future updates, I suggest to avoid mentioning the soversion:
  %{_libdir}/libgraphite2.so.*

But that's optional. The package is ready anyway.


$ rpmlint ./graphite2-*.rpm
graphite2.x86_64: W: no-manual-page-for-binary gr2fonttest
graphite2.x86_64: W: no-manual-page-for-binary comparerenderer
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    - LGPLv2+ according to source file headers

[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum graphite2-1.0.2.tgz*
    3115c721f5cb7c464f01c2dddccfaba6  graphite2-1.0.2.tgz
    3115c721f5cb7c464f01c2dddccfaba6  graphite2-1.0.2.tgz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    - koji scratch build:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=3285384

[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...

[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[.] MUST: The spec file MUST handle locales properly.
[+] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[+] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[+] MUST: If a package contains .so files with a suffix, then .so (without
suffix) must go in a -devel package.
[+] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

EPEL <= 5 only:
[X] MUST: The spec file must contain a valid BuildRoot field.
[X] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[X] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.
[X] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'


[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[X] SHOULD: Your package should contain man pages for binaries/scripts.

----------------
Package APPROVED
----------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.