[Bug 726131] Review Request: yourls - your own url shortening service
bugzilla at redhat.com
bugzilla at redhat.com
Fri Aug 19 13:32:37 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=726131
Martin Gieseking <martin.gieseking at uos.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|177841(FE-NEEDSPONSOR) |
--- Comment #11 from Martin Gieseking <martin.gieseking at uos.de> 2011-08-19 09:32:35 EDT ---
Here's the formal review. The package is almost ready. There are two things
left that need to be fixed:
- The package contains several files under different licenses, so we have a
multiple licensing scenario here:
* yourls files: GPL+
* GeoIP files: LGPLv2+
* JQuery files: MIT or GPLv2
=> the License field should look like this:
GPL+ and LGPLv2+ and (MIT or GPLv2)
Also, add a comment about the multiple licensing scenario and the
corresponding files above the License field.
- Since the yourls archive doesn't contain a license file, ask upstream to
add one to a future release.
- Some of the doc files have DOS line endings (see rpmlint output). You can
fix this by adding the following loop to the %prep section:
for f in *.txt; do
sed 's/\r//' $f > $f.new &&
touch -r $f $f.new &&
mv $f.new $f
done
$ rpmlint *.rpm
yourls.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/yourls-1.5/sample-public-api.php.txt
yourls.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/yourls-1.5/sample-public-front-page.php.txt
yourls.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/yourls-1.5/changelog.txt
yourls.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/yourls-1.5/sample-remote-api-call.php.txt
yourls.src: W: invalid-url Source0:
http://yourls.googlecode.com/files/yourls-1.5.zip HTTP Error 404: Not Found
2 packages and 0 specfiles checked; 0 errors, 5 warnings.
---------------------------------
key:
[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
- multiple licensing scenario:
* GeoIP: LGPLv2+
* JQuery: MIT or GPLv2
[X] MUST: The License field in the package spec file must match the actual
license.
[.] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum yourls-1.5.zip*
fa32943f7d669640f08670ecdcde5ad1 yourls-1.5.zip
fa32943f7d669640f08670ecdcde5ad1 yourls-1.5.zip.upstream
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture.
[.] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
EPEL <= 5 only:
[+] MUST: The spec file must contain a valid BuildRoot field.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.
[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[X] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[.] SHOULD: Your package should contain man pages for binaries/scripts.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list