[Bug 715180] Review Request: FreeMat - A free environment for rapid engineering, scientific prototyping and data processing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715180

--- Comment #20 from Richard Shaw <hobbes1069 at gmail.com> 2011-08-19 09:52:59 EDT ---
Some observations I had while reviewing the spec file:

1. Should the -data sub-package be set as noarch?

2. I cleaned up the %cmake line for readability. Not a must, but... :)

%cmake -DFORCE_SYSTEM_LIBS=ON \
       -DFFI_INCLUDE_DIR:PATH=%{_libdir}/libffi-3.0.9/include/ \
       -DBUILD_SHARED_LIBS=OFF \
       -DUSE_VTK=ON \
       ./

Also, it's a good idea to put two blank lines between major sections (%prep,
%build, %install, etc.) I only put one blank line between similar sections
(%files, %files doc, %files devel, etc.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.