[Bug 715180] Review Request: FreeMat - A free environment for rapid engineering, scientific prototyping and data processing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715180

--- Comment #21 from Ankur Sinha <sanjay.ankur at gmail.com> 2011-08-20 02:18:24 EDT ---

(In reply to comment #20)
> Some observations I had while reviewing the spec file:
> 
> 1. Should the -data sub-package be set as noarch?
> 
> 2. I cleaned up the %cmake line for readability. Not a must, but... :)
> 
> %cmake -DFORCE_SYSTEM_LIBS=ON \
>        -DFFI_INCLUDE_DIR:PATH=%{_libdir}/libffi-3.0.9/include/ \
>        -DBUILD_SHARED_LIBS=OFF \
>        -DUSE_VTK=ON \
>        ./
> 
> Also, it's a good idea to put two blank lines between major sections (%prep,
> %build, %install, etc.) I only put one blank line between similar sections
> (%files, %files doc, %files devel, etc.)

I'm looking into whether the data package should be noarch. The docs is
definitely a noarch. 

The desktop and blas.ini files can go in either the main package or the data
package. I had broken it down for the sake of organization. What do you
suggest?

I'm making the tweaks and trying to build it. Koji is running. I'll submit an
updated spec in a bit. 

Thanks :)
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.