[Bug 731820] Review Request: kcm-qt-graphicssystem - Easily configure the standard Qt graphics system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=731820

Kalev Lember <kalevlember at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Kalev Lember <kalevlember at gmail.com> 2011-08-20 03:45:11 EDT ---
Fedora review kcm-qt-graphicssystem-1.2-1.fc15.src.rpm  2011-08-20

+ OK
! needs attention

koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3288557

$ rpmlint kcm-qt-graphicssystem-1.2-1.fc16.src.rpm \
          kcm-qt-graphicssystem-1.2-1.fc16.x86_64.rpm \
          kcm-qt-graphicssystem-debuginfo-1.2-1.fc16.x86_64.rpm
kcm-qt-graphicssystem.src:2: W: mixed-use-of-spaces-and-tabs (spaces: line 2,
tab: line 2)
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

! rpmlint warning is harmless, but would be nice to make it happy
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the package base name
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  aef872cb2e892891a813026b0a8156f5  129817-kcm-qt-graphicssystem-1.2.tar.xz
  aef872cb2e892891a813026b0a8156f5 
Download/129817-kcm-qt-graphicssystem-1.2.tar.xz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ No duplicated files in %files section
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
  It's a plugin package, not applicable.
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8


Remaining issues:
 - there are trailing tabs on lines 2 and 8 which rpmlint is complaining about
 - should probably use %{?_isa} to tighten the kdebase-runtime requires

These are all minor issues and can all be fixed before importing the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.