[Bug 728956] Review Request: php-virt-control - PHP-based virtual machine controller tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728956

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com

--- Comment #1 from Remi Collet <fedora at famillecollet.com> 2011-08-20 04:38:49 EDT ---
As this package don't work,, I can't do the review for now.

First notes:

Don't need to require a "webserver" as this application could be, as all
web-app, installed on 1 server and used from another workstation.

According to PHP Compatinfo analysis should requires php-gd and php-mysql
$ phpci print --report=extension --recursive php-virt-control-0.0.2/
33 / 33 [+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++>] 100.00%
BASE: /home/extras/SPECS/review/php-virt-control-0.0.2
-------------------------------------------------------------------------------
PHP COMPAT INFO EXTENSION SUMMARY
-------------------------------------------------------------------------------
  EXTENSION                                        PECL   VERSION         COUNT
-------------------------------------------------------------------------------
  Core                                                    4.0.0             238
  date                                                    4.0.0               1
  gd                                                      4.0.0              14
  mysql                                              1.0  4.0.0               9
  session                                                 4.0.0               1
  standard                                                4.0.0             411
-------------------------------------------------------------------------------
A TOTAL OF 6 EXTENSION(S) WERE FOUND
REQUIRED PHP 4.0.0 (MIN) 

Should also requires "php" (and so, httpd)

Please add "Allow From ::1" in php-virt-control.conf

This app use <?=
This requires the short_open_tag deprecated and discouraged option.

So 
- add in php-virt-control.conf (only for this app)
    php-flag short_open_tag On
- report this as a bug to upstream

On first call to http://localhost/php-virt-control/
Warning: libvirt_check_version(): Invalid version type in
/usr/share/php-virt-control/init.php on line 51 Call Stack: 
0.0003 659224 1. {main}() /usr/share/php-virt-control/index.php:0 
0.0003 659664 2. require('/usr/share/php-virt-control/init.php')
/usr/share/php-virt-control/index.php:2 
0.0009 791704 3. libvirt_check_version()
/usr/share/php-virt-control/init.php:51 

And => 
Update needed:
Your version of libvirt-php module is too old for this application to work
properly. Please upgrade your libvirt-php version from http://libvirt.php
first.

Despite I have installed the latest version available
$ rpm -q php-libvirt 
php-libvirt-0.4.3-1.fc15 (x86_64)
$ php -r 'print_r( libvirt_version() );'
Array
(
    [libvirt.release] => 8
    [libvirt.minor] => 8
    [libvirt.major] => 0
    [connector.version] => 0.4.3
    [connector.major] => 0
    [connector.minor] => 4
    [connector.release] => 3
)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.