[Bug 732205] Review Request: airsched - C++ Simulated Airline Schedule Manager Library
bugzilla at redhat.com
bugzilla at redhat.com
Sun Aug 21 00:16:18 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=732205
Volker Fröhlich <volker27 at gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |volker27 at gmx.at
--- Comment #1 from Volker Fröhlich <volker27 at gmx.at> 2011-08-20 20:16:18 EDT ---
Some quick comments:
Drop the README file, as it only contains instructions on how to install.
The doc package should require the base package. Drop COPYING from the doc
sub-package, as the base package provides it.
"This package contains the documentation in the HTML format of the %{name}
library." -- That's probably not perfect English.
Your devel sub-package does not contain static libraries, as the description
claims.
State BuildRequires per package -- not per sub-package.
The two chmods serve no purpose.
You can use the name macro on this line: %{_libdir}/lib*.so.*
You're packaging manpage 1 twice.
I think, you don't have to package the m4 file.
"Install the %{name} package if you need a library for simulated Schedule
Management C++ library." -- A library for a library?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list