[Bug 675234] Review Request: duply - Wrapper for duplicity

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675234

Jorge A Gallegos <kad at blegh.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kad at blegh.net

--- Comment #6 from Jorge A Gallegos <kad at blegh.net> 2011-08-21 18:41:15 EDT ---
*** I am not a packager yet, but here are some comments ***

 - In your spec file, in %files, defattr() is no longer needed
(http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions)
 - Your package appears to be ready for EPEL, in case you want to include it
there as well... if not, you'll need to get rid of all the BuildRoot stuff
(http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag)
 - I would suggest renaming gpl-2.0.txt to LICENSE in %build and then change it
in %doc as well, just because it is consistent with most other packages out
there. This is not required by the guidelines though, so it's up to you
(http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation).

rpmlint output:
---------------------------------------------
rpmlint -i duply.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[kad at propane SPECS ]$ rpmlint -i ../SRPMS/duply-1.5.5.1-1.fc15.src.rpm 
duply.src: W: spelling-error %description -l en_US cron -> corn, con, crone
The value of this tag appears to be misspelled. Please double-check.

duply.src: W: spelling-error %description -l en_US pre -> per, ore, pee
The value of this tag appears to be misspelled. Please double-check.

duply.src: W: spelling-error %description -l en_US backends -> back ends,
back-ends, backhands
The value of this tag appears to be misspelled. Please double-check.

duply.src: W: spelling-error %description -l en_US ftplicity -> duplicity
The value of this tag appears to be misspelled. Please double-check.

1 packages and 0 specfiles checked; 0 errors, 4 warnings.
--------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.