[Bug 732419] Review Request: esteid-browser-plugin - Estonian ID card digital signing browser plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732419

--- Comment #2 from Rex Dieter <rdieter at math.unl.edu> 2011-08-22 12:17:40 EDT ---
scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3291943

$ rpmlint *.rpm
esteid-browser-plugin.src: W: spelling-error %description -l en_US eID -> ID,
CID, e ID
esteid-browser-plugin.src: W: spelling-error %description -l en_US whitelist ->
white list, white-list, Whiteley
esteid-browser-plugin.src: W: invalid-url Source1:
http://esteid.googlecode.com/files/esteid-browser-plugin-1.3.0.tar.bz2 HTTP
Error 404: Not Found
esteid-browser-plugin.src: W: invalid-url Source0:
http://firebreath.googlecode.com/files/firebreath-1.5.2.tar.bz2 HTTP Error 404:
Not Found
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

mostly harmless

sources: ok
$ md5sum *.bz2
174ba07a9adf4a8419db8aa47bf33ecb  esteid-browser-plugin-1.3.0.tar.bz2
14e5854f90655f87eddf6d0d5f735f46  firebreath-1.5.2.tar.bz2

license: MUST: please review
from my quick looking over, most of the code seems to be dual-licensed: BSD or
LGPLv2
log4cplus is apache (not sure if that's actually used in the build.. yet)

naming: ok
though I have some reservations about the combining of 2 tarball/projects into
one package here, but perhaps that's the upstream design here (i'm not familiar
with it enough to judge).  if so, please do add a comment in the .spec to make
that clear.

macros: ok

scriptlets: n/a

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.