[Bug 723752] Review Request: lrslib - Reverse search for vertex enumeration/convex hull problems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=723752

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #1 from Volker Fröhlich <volker27 at gmx.at> 2011-08-22 15:42:56 EDT ---
Just a few basic notes:

[makerpm at lenovo SRPMS]$ rpmlint ~/rpmbuild/SRPMS/lrslib-4.2c-1.fc15.src.rpm
~/rpmbuild/RPMS/x86_64
lrslib.x86_64: W: no-documentation
lrslib.x86_64: W: no-manual-page-for-binary lrs-setupnash2
lrslib.x86_64: W: no-manual-page-for-binary lrs
lrslib.x86_64: W: no-manual-page-for-binary lrs-float2rat
lrslib.x86_64: W: no-manual-page-for-binary lrs-nash
lrslib.x86_64: W: no-manual-page-for-binary lrs-rat2float
lrslib.x86_64: W: no-manual-page-for-binary lrs-fourier
lrslib.x86_64: W: no-manual-page-for-binary lrs-redund
lrslib.x86_64: W: no-manual-page-for-binary lrs-setupnash
lrslib.x86_64: W: no-manual-page-for-binary lrs-2gnash
lrslib.x86_64: W: no-manual-page-for-binary lrs-buffer
lrslib-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/lrslib-042c/lrslib.c
lrslib-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/lrslib-042c/lrslib.h
lrslib-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/lrslib-042c/lrsmp.c
lrslib-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/lrslib-042c/lrsgmp.h
lrslib-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/lrslib-042c/lrsmp.h
lrslib-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/lrslib-042c/lrslong.h
lrslib-devel.x86_64: E: incorrect-fsf-address /usr/include/lrslib/lrslib.h
lrslib-devel.x86_64: E: incorrect-fsf-address /usr/include/lrslib/lrsgmp.h
lrslib-devel.x86_64: E: incorrect-fsf-address /usr/include/lrslib/lrslong.h
lrslib-devel.x86_64: E: incorrect-fsf-address /usr/include/lrslib/lrsmp.h
lrslib-libs.x86_64: W: spelling-error %description -l en_US cdd -> dd, cad, add
lrslib-libs.x86_64: W: spelling-error %description -l en_US cddlib -> puddling
lrslib-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/liblrsmp.so.4.2
exit at GLIBC_2.2.5
lrslib-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/liblrsgmp.so.4.2
exit at GLIBC_2.2.5
lrslib-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/liblrslong.so.4.2
exit at GLIBC_2.2.5
lrslib-libs.x86_64: E: incorrect-fsf-address
/usr/share/doc/lrslib-libs-4.2c/COPYING
5 packages and 0 specfiles checked; 11 errors, 16 warnings.

Please ask the developers to update the FSF address and also let them know
about the lib calling exit.

Use the name macro instead of always writing "lrslib". E. g. Requires:      
%{name}-libs%{?_isa} = %{version}-%{release}

If you use it in the description as well, is up to you.

Use %global instead of %define. See
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.