[Bug 732651] Review Request: sshpass - Non-interactive ssh authentication utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732651

--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2011-08-23 05:48:06 EDT ---
Formal notice: Reports in Package Review component should stick on review
template. I.e. spec URL, SPRM, URL, and Description. Additional text should
follow after these three items.

Source tar ball is original. Ok.

TODO: Uppercase `ssh' in Summary if this tool works (or should work) with other
SSH implementations providing SSH client under different name than `ssh'.

FIXME: COPYING delivers GPLv2 and main.c states GPLv2+, but AUTHORS says GPLv2
only. Correct License tag or ask upstream for clarification.

TODO: Normalize home page URL. I.e. append slash.

TODO: Correct spelling in Description. Namely leading word `Sshpass' is name of
the tool and the tool, package, and even project is called `sshpass'. You can
remove the beginning completely (Sshpass is a) to obey orthographic rules.
Remove the abbreviated possession "'s" from "SSH's" as it can be used only to
possess to life entities. The `SSH' becomes attribute automatically per English
syntax rules.

TODO: Add %{?_smp_mflags} argument to `make' command to utilize parallel
building, if the Makefile is not broken. (I know there is only one source file
now, but it can help if upstream decides to use more source files.)

TODO: Remove useless %defattr macro in %files section as this is implicit.

FIX: Package as documentation (macro %doc) files: AUTHORS, ChangeLog, NEWS.

$ rpmlint sshpass.spec ../SRPMS/sshpass-1.05-1.fc15.src.rpm
../RPMS/x86_64/sshpass-*
sshpass-debuginfo.x86_64: W: invalid-url URL: http://sshpass.sourceforge.net
HTTP Error 403: Forbidden
sshpass-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/sshpass-1.05/main.c
sshpass.x86_64: W: invalid-url URL: http://sshpass.sourceforge.net HTTP Error
403: Forbidden
3 packages and 1 specfiles checked; 1 errors, 2 warnings.

TODO: Notify upstream to fix FSF address. You can link to
<http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt>.

rpmlint Ok.


$ rpm -q -lv -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm 
-rwxr-xr-x    1 root    root                    11192 srp 23 11:35
/usr/bin/sshpass
-rw-r--r--    1 root    root                     2192 srp 23 11:35
/usr/share/man/man1/sshpass.1.gz
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm |sort
libc.so.6(GLIBC_2.2.5)(64bit)  
libc.so.6(GLIBC_2.3.4)(64bit)  
libc.so.6(GLIBC_2.4)(64bit)  
libc.so.6()(64bit)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)  

Binary requires Ok.

$ rpm -q --provides  -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm |sort
sshpass(x86-64) = 1.05-1.fc15
sshpass = 1.05-1.fc15

Binary provides Ok.

Binary dependencies resolvable. Ok.

Package builds in F17
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3294476). Ok.

Otherwise package is in line with Fedora packaging guidelines.


Please correct all `FIX' prefixed issues, consider fixing `TODO' prefixed items
and provide new spec file.

Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.