[Bug 726131] Review Request: yourls - your own url shortening service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=726131

--- Comment #13 from Martin Krizek <mkrizek at redhat.com> 2011-08-23 08:06:12 EDT ---
(In reply to comment #11)
> Here's the formal review. The package is almost ready. There are two things
> left that need to be fixed:
> 
> - The package contains several files under different licenses, so we have a
>   multiple licensing scenario here:
>   * yourls files: GPL+
>   * GeoIP files: LGPLv2+
>   * JQuery files: MIT or GPLv2
> 
> => the License field should look like this: 
>    GPL+ and LGPLv2+ and (MIT or GPLv2)
>    Also, add a comment about the multiple licensing scenario and the
>    corresponding files above the License field.
> 
> - Some of the doc files have DOS line endings (see rpmlint output). You can
>   fix this by adding the following loop to the %prep section:
> 
>   for f in *.txt; do
>     sed 's/\r//' $f > $f.new &&
>     touch -r $f $f.new &&
>     mv $f.new $f
>   done
> 
Fixed:

$ rpmlint rpmbuild/SPECS/yourls.spec rpmbuild/SRPMS/yourls-1.5-4.fc15.src.rpm
rpmbuild/RPMS/noarch/yourls-1.5-4.fc15.noarch.rpm 
rpmbuild/SPECS/yourls.spec: W: invalid-url Source0:
http://yourls.googlecode.com/files/yourls-1.5.zip HTTP Error 404: Not Found
yourls.src: W: invalid-url Source0:
http://yourls.googlecode.com/files/yourls-1.5.zip HTTP Error 404: Not Found
2 packages and 1 specfiles checked; 0 errors, 2 warnings.


Spec URL: http://mkrizek.fedorapeople.org/yourls.spec
SRPM URL: http://mkrizek.fedorapeople.org/yourls-1.5-4.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.