[Bug 731898] Review Request: opendkim - DKIM library and milter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=731898

--- Comment #21 from Matt Domsch <matt_domsch at dell.com> 2011-08-23 10:19:35 EDT ---
Review:
* rpmlint: see below
* name: OK
* spec file name matches: OK
* packaging guidelines: OK
* licensed: OK
* license tag: change to "BSD and Sendmail"
* license in %doc: OK
* english spec: OK
* legible spec: OK
* sources match upstream: OK
* builds on one arch: OK
* exclusivearch?: OK
* BuildRequires: OK (after fixing pkgconfig noted above)
* locales: OK (N/A)
* shared libs invoke ldconfig: OK
* no system libs: OK
* relocatable?: OK (N/A)
* owns dirs: OK
* no files more than once: OK
* permissions:  (re-check)
* macros: OK
* code or content: OK
* large docs: OK (N/A)
* docs don't affect runtime: OK
* headers in -devel: OK
* static libs in -static: OK (N/A)
* .so in -devel: OK
* -devel requires fully versioned base package: Needs to be fixed
* No .la files: OK
* desktop file: OK (N/A)
* directory ownership: OK
* UTF-8 filenames: OK




$ rpmlint SPECS/opendkim.spec SRPMS/opendkim-2.4.2-3.fc14.src.rpm RPMS/x86_64/*
SPECS/opendkim.spec:67: W: macro-in-comment %{_docdir}
SPECS/opendkim.spec:67: W: macro-in-comment %{name}
SPECS/opendkim.spec:67: W: macro-in-comment %{version}
SPECS/opendkim.spec:67: W: macro-in-comment %{name}
SPECS/opendkim.spec:75: W: macro-in-comment %{_docdir}
SPECS/opendkim.spec:75: W: macro-in-comment %{name}
SPECS/opendkim.spec:75: W: macro-in-comment %{version}
SPECS/opendkim.spec:107: W: macro-in-comment %{_localstatedir}
SPECS/opendkim.spec:107: W: macro-in-comment %{name}
SPECS/opendkim.spec:128: W: macro-in-comment %{_sysconfdir}
SPECS/opendkim.spec:128: W: macro-in-comment %{name}
SPECS/opendkim.spec:133: W: macro-in-comment %{_sysconfdir}
SPECS/opendkim.spec:133: W: macro-in-comment %{name}
SPECS/opendkim.spec:137: W: macro-in-comment %{_sysconfdir}
SPECS/opendkim.spec:137: W: macro-in-comment %{name}
SPECS/opendkim.spec:140: W: macro-in-comment %{_sysconfdir}
SPECS/opendkim.spec:140: W: macro-in-comment %{name}
opendkim.src: W: spelling-error %description -l en_US sendmail -> send mail,
send-mail, Sendai
opendkim.src:67: W: macro-in-comment %{_docdir}
opendkim.src:67: W: macro-in-comment %{name}
opendkim.src:67: W: macro-in-comment %{version}
opendkim.src:67: W: macro-in-comment %{name}
opendkim.src:75: W: macro-in-comment %{_docdir}
opendkim.src:75: W: macro-in-comment %{name}
opendkim.src:75: W: macro-in-comment %{version}
opendkim.src:107: W: macro-in-comment %{_localstatedir}
opendkim.src:107: W: macro-in-comment %{name}
opendkim.src:128: W: macro-in-comment %{_sysconfdir}
opendkim.src:128: W: macro-in-comment %{name}
opendkim.src:133: W: macro-in-comment %{_sysconfdir}
opendkim.src:133: W: macro-in-comment %{name}
opendkim.src:137: W: macro-in-comment %{_sysconfdir}
opendkim.src:137: W: macro-in-comment %{name}
opendkim.src:140: W: macro-in-comment %{_sysconfdir}
opendkim.src:140: W: macro-in-comment %{name}
libopendkim.x86_64: E: postin-without-ldconfig /usr/lib64/libopendkim.so.5.0.1
libopendkim.x86_64: E: non-empty-%post /sbin/ldconfig
libopendkim-devel.x86_64: W: no-version-dependency-on
libopendkim/libopendkim-libs/liblibopendkim 2.4.2
opendkim.x86_64: W: spelling-error %description -l en_US sendmail -> send mail,
send-mail, Sendai
opendkim.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/opendkim-genzone
['/usr/lib64']
opendkim.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/opendkim-stats
['/usr/lib64']
opendkim.x86_64: E: binary-or-shlib-defines-rpath /usr/sbin/opendkim
['/usr/lib64']
opendkim.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/opendkim-testkey
['/usr/lib64']
opendkim.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/opendkim-testadsp
['/usr/lib64']
opendkim.x86_64: W: non-standard-uid /etc/opendkim/keys opendkim
opendkim.x86_64: W: non-standard-gid /etc/opendkim/keys opendkim
opendkim.x86_64: W: non-standard-uid /var/run/opendkim opendkim
opendkim.x86_64: W: non-standard-gid /var/run/opendkim opendkim
opendkim.x86_64: W: dangerous-command-in-%preun userdel
opendkim.x86_64: W: service-default-enabled /etc/rc.d/init.d/opendkim
opendkim.x86_64: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/opendkim
opendkim-debuginfo.x86_64: E: non-standard-dir-perm /usr/lib/debug 0775L
opendkim-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/opendkim-2.4.2 0775L
5 packages and 1 specfiles checked; 9 errors, 44 warnings.


The above macro-in-comment bits can be solved using %%{_foo} if necessary in
the comment sections.

Ignore spelling error.

postin-without-ldconfig and non-empty-post are odd; worth looking into, but
they should be OK...

no-version-dependency: caught above on review, needs fixing.

rpath: ugh.  Needs fixing. 
http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath

non-standard-uid/gid: OK.

dangerous command userdel: caught above, needs fixing.

service-default-enabled: needs fixing by patching initscript
missing-lsb-keyword: needs fixing by patching initscript
non-standard-dir-perm: ignore, it's a bug in rpmlint. :-)


File permissions show /usr/share/doc/*/convert_keylist.sh is marked executable.
 In %install, chmod it 0644.

API documentation currently in /usr/share/doc/libopendkim-2.4.2/*.html should
only be in the -devel subpackage, not in both.

Fixing the above, then I'll check the review again.

Thanks,
Matt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.