[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732552

--- Comment #6 from T.C. Hollingsworth <tchollingsworth at gmail.com> 2011-08-23 12:04:28 EDT ---
Thank you for taking this on, and all your other help!

(In reply to comment #3)
> * I don't know if it is my English as a second language or what, but I don't
> understand this
> 
> # some partially generated docs in the tarball gum up the works
> rm -rf doc/api/api
> 
> What's going on?

Your English is fine, it's mine that leaves a little to be desired.  ;-)

Upstream ships API docs in doc/api in Markdown format, which are turned into
HTML by "make doc".  Unfortunately, they also shipped partially generated ones
in doc/api/api, and "make doc" tries to convert those too, but fails because
they're not markdown.  I rewrote that comment to be more clear.

> * mv doc/nodejs.1.gz %{buildroot}%{_mandir}/man1/
> please don't mv, do rather cp -p ... instead. There could be an issue with
> SELinux labels, ownerships etc. corrupted.

Fixed.

> * failing tests
> # Fails 5 tests ATM
> # known upstream: https://github.com/joyent/node/pull/1021
> ##%%check
> ##cd build
> ##ctest
> 
> Not reason to break the review, but couldn't you just switch off just the
> specific tests (renaming the file with test should help or something)?

I have identified and disabled the broken tests and re-enabled %check.

> * %doc %{_mandir}/man1/nodejs.1.gz
> No, it is not %doc. %doc should be README.md, LICENSE etc., not manpage.

Fixed.

>Isn't this nodejs still dependent on v8 from the repo outside of Fedora? This
package review is blocked by bug 732213 where we need to resolve this mess.

(In reply to comment #5)
>But in koji this doesn't build
>http://koji.fedoraproject.org/koji/taskinfo?taskID=3295369

Actually, it builds fine with the V8 currently in the main Fedora repo. 
http-parser was breaking the build.  When I force the bundled http-parser, it
builds fine on Koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=3295572

It also builds fine locally with the RPM you pushed to bodhi yesterday.

--

Spec: http://www.u.arizona.edu/~tchol/fedora/nodejs.spec
SRPM: http://www.u.arizona.edu/~tchol/fedora/nodejs-0.4.11-2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.