[Bug 719103] Review Request: mex - Media centre application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719103

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #2 from Volker Fröhlich <volker27 at gmx.at> 2011-08-23 12:13:59 EDT ---
rpmlint mex-0.1.4-1.fc17.x86_64.rpm 
mex.x86_64: W: spelling-error Summary(en_US) centre -> center, cent re, cent-re
mex.x86_64: W: spelling-error %description -l en_US centre -> center, cent re,
cent-re
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/40mex-recommended.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/100mex-debug.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/20mex-gnome-dvb.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/40mex-queue.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/00mex-search.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/20mex-tracker.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/20mex-upnp.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mex-webremote
['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mex ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/50mex-dbusinput.so ['/usr/lib64']
mex.x86_64: E: incorrect-fsf-address /usr/share/doc/mex-0.1.4/COPYING
mex.x86_64: E: postun-without-ldconfig /usr/lib64/libmex-0.2.so.0.0.0
mex.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libmex-0.2.so
mex.x86_64: W: no-manual-page-for-binary mex-webremote
mex.x86_64: W: no-manual-page-for-binary mex-debug
mex.x86_64: W: no-manual-page-for-binary mex

Get rid of the rpaths. See
http://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath

Please contact the developer, so he can update the license file with the one up
to date. You may opt to correct the address in the package.

Libs in standard directories need an ldconfig run. See
http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

You'll need a devel sub-package:
http://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages

Installing files to /usr/share/icons, you need this scriptlet:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

Use the name macro instead of "mex".

Try to break the %configure line.

You can drop the defattr line. It's not necessary.

If you don't plan to go for EPEL5 or older, drop the clean section and the rm
in the install section. If you want to go for EPEL5, define the buildroot.

Be more specific in your file section. For instance: all binaries start with
%{name}.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.