[Bug 731898] Review Request: opendkim - DKIM library and milter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=731898

--- Comment #23 from Steve Jenkins <steve at stevejenkins.com> 2011-08-23 12:50:54 EDT ---
(In reply to comment #21)
> The above macro-in-comment bits can be solved using %%{_foo} if necessary in
> the comment sections.

Those are from the comments that the echoed config file, so I want those
variables to be parsed. Is it OK to leave these warnings? 

> Ignore spelling error.

I awlays do.

> postin-without-ldconfig and non-empty-post are odd; worth looking into, but
> they should be OK...

You're right - from what I Googled on the subject, the postin-without-ldconfig
rpmlint error was benign in most cases. However, Google returned absolutely
ZERO results for "rpmlint 'non-empty-post'" or "rpmlint 'non-empty-%post'" Is
rmplint complaining that the output of that %post wasn't empty, when it
expected it to be?

Also, my rpmlint output isn't showing these errors (on an i686 FC box). I'm
running v1.2. Are you running a newer version?

> no-version-dependency: caught above on review, needs fixing.

Is this something that needs to be fixed in the spec file or the upstream?

> rpath: ugh.  Needs fixing. 
> http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath

Mmmmyeeeahhh..... Ugh. This is what the ifarch funkiness in the original
version of the spec file was for. Refer to Todd's comments above. I've added
the LIBTOOL stuff back in so that it forces the use of the system's libtool
instead of the one in the source.

> non-standard-uid/gid: OK.
> 
> dangerous command userdel: caught above, needs fixing.

You must have grabbed the spec before I had a chance to upload that change
based on your feedback earlier this morning. That *should* be fixed, as I
removed the group and user delete.

> service-default-enabled: needs fixing by patching initscript
> missing-lsb-keyword: needs fixing by patching initscript

Got rid of the missing-lsb-keyword, but the service-default-enabled is still
hanging around. Can you give me a nudge toward what might be causing that?

> non-standard-dir-perm: ignore, it's a bug in rpmlint. :-)

Freebie! Yay!

> File permissions show /usr/share/doc/*/convert_keylist.sh is marked executable.
>  In %install, chmod it 0644.

Fixed.

> API documentation currently in /usr/share/doc/libopendkim-2.4.2/*.html should
> only be in the -devel subpackage, not in both.

Looking in to this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.