[Bug 732159] Review Request: libmnl - A minimalistic Netlink library

bugzilla at redhat.com bugzilla at redhat.com
Tue Aug 23 20:24:51 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732159

Mario Blättermann <mariobl at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl at freenet.de

--- Comment #3 from Mario Blättermann <mariobl at freenet.de> 2011-08-23 16:24:50 EDT ---
(In reply to comment #2)
> the buildroot is cleaned by rm -rf $RPM_BUILD_ROOT in install stage, also about
> wildcards in files section, is the packaging guide changed? This is OK before,
> and many packages use this.

It is only needed for older EPEL packages. You might drop the BuildRoot line
[1], the %clean section [2] and the %defattr macro [3] in %files, if you don't
want to provide your package for EPEL 5 or older.

[1] http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
[2] http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
[3] http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list