[Bug 731898] Review Request: opendkim - DKIM library and milter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=731898

--- Comment #28 from Steve Jenkins <steve at stevejenkins.com> 2011-08-23 16:35:50 EDT ---
(In reply to comment #26)
> much improved.  I see the current initscript patch still has:
> 
> # chkconfig: - 41 59
> 
> (this is good)

Yay!

> # Required-Start: opendkim
> # Required-Stop: opendkim
> # Default-Start: 2 3 4 5
> # Default-Stop: 0 1 6

> (this is wrong: delete default-start and -stop lines)

Boo! I've deleted all four of these.

> Each of the subpackages needs a %doc that includes LICENSE and
> LICENSE.Sendmail.  I know, it's annoying, but they can be installed separately.

I added them in both with %doc.

> otherwise, rpmlint looks good now (I'm using Fedora 14 to build and run
> rpmlint).  Everything else looks good.

I've been testing on Fedora 15 i686, and Todd's been testing on CentOS 5.6
x86_86. Our rpmlints look equally clean, the RPMs build and install on both.

> Sorry for the mess around libtool.  What you've got now seems to be OK, no more
> rpaths either, yea!

We scratched our heads a bit, but yeah - I think this is probably the best way
to deal with it. The developer is always keen for feedback, so perhaps we'll
suggest that he not even try to build libtool if it's already in the path.

> Fix these two, and I'll mark approved.

New spec and SRPM at:

http://packages.stevejenkins.com/opendkim/2.4.2/working/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.