[Bug 732651] Review Request: sshpass - Non-interactive ssh authentication utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732651

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Petr Pisar <ppisar at redhat.com> 2011-08-24 08:12:44 EDT ---
Spec file changes:

--- sshpass.spec 2011-08-23 13:44:59.000000000 +0200
+++ sshpass.spec.1 2011-08-24 13:50:00.000000000 +0200
@@ -1,4 +1,4 @@
-Summary:    Non-interactive ssh authentication utility
+Summary:    Non-interactive SSH authentication utility
 Name:       sshpass
 Version:    1.05
 Release:    1%{?dist}
@@ -25,7 +25,7 @@
 %files
 %{_bindir}/sshpass
 %{_datadir}/man/man1/sshpass.1.gz
-%doc AUTHORS ChangeLog NEWS
+%doc AUTHORS COPYING ChangeLog NEWS

 %changelog


> > > TODO: Uppercase `ssh' in Summary if this tool works (or should work) with
> > > other SSH implementations providing SSH client under different name than
> > > `ssh'.
> > Uppercased
> TODO: I cannot see the change.
-Summary:    Non-interactive ssh authentication utility
+Summary:    Non-interactive SSH authentication utility
Ok.

> I forgot you need to package COPYING file using %doc macro.
-%doc AUTHORS ChangeLog NEWS
+%doc AUTHORS COPYING ChangeLog NEWS
Ok.


$ rpmlint sshpass.spec ../SRPMS/sshpass-1.05-1.fc15.src.rpm
../RPMS/x86_64/sshpass-*
sshpass-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/sshpass-1.05/main.c
sshpass.x86_64: W: invalid-url URL: http://sshpass.sourceforge.net/ HTTP Error
403: Forbidden
sshpass.x86_64: E: incorrect-fsf-address /usr/share/doc/sshpass-1.05/COPYING
3 packages and 1 specfiles checked; 2 errors, 1 warnings.

rpmlint Ok.

$ rpm -q -lv -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm 
-rwxr-xr-x    1 root    root                    11192 srp 24 14:06
/usr/bin/sshpass
drwxr-xr-x    2 root    root                        0 srp 24 14:06
/usr/share/doc/sshpass-1.05
-rw-r--r--    1 root    root                      700 čec 22  2010
/usr/share/doc/sshpass-1.05/AUTHORS
-rw-r--r--    1 root    root                    17992 čec 22  2010
/usr/share/doc/sshpass-1.05/COPYING
-rw-r--r--    1 root    root                     1455 srp  6 09:02
/usr/share/doc/sshpass-1.05/ChangeLog
-rw-r--r--    1 root    root                      213 čec 22  2010
/usr/share/doc/sshpass-1.05/NEWS
-rw-r--r--    1 root    root                     2192 srp 24 14:06
/usr/share/man/man1/sshpass.1.gz
File permissions and layout are Ok.

Package builds in F17 (). ???

Package is in line with Fedora and Perl packaging guidelines.


Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.