[Bug 710905] Review Request: octave-optim - Optimization for Octave

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710905

--- Comment #9 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-08-24 13:14:19 EDT ---
(In reply to comment #8)
> > looks *really* odd. Did you get an rpmlint warning about text in the wrong
> > encoding? I'm not a PostScript expert, but I'd leave these files as-is.
> 
> You are right, it is wrong.
> 
> But now I get the following lint warnings:
> 
> octave-optim.x86_64: W: file-not-utf8
> /usr/share/octave/packages/optim-1.0.16/doc/figures/2D_slice-3.eps2
> octave-optim.x86_64: W: file-not-utf8
> /usr/share/octave/packages/optim-1.0.16/doc/figures/optim_tutorial_slice.eps
> 
> I think these warnings are bogus, they are coming from a binary portion of the
> eps file.

Yes. rpmlint often causes false alarms.

> > MUST: The License field in the package spec file must match the actual license.
> > NEEDSWORK
> 
> Well, the DESCRIPTION file contained in the source archive lists GFDL as well
> as GPLv2+, so that's why it is listed in the RPM license field as well.

OK. Now I see that optim-mini-howto-2.lyx specifies that it is under the GFDL.
But I also now notice that many files that were not examined by licensecheck
specify GPLv3+. So the correct tag is
 License: GPLv2+ and GPLv3+ and GFDL.

I don't see the point in shipping a LyX file (or the Makefile!), so you should
compile the documentation by adding
 BuildRequires: tex(latex)
and running
 make -C doc DVIPDF=dvipdf optim-mini-howto-2.pdf
in %build.

Then, at the end of %install run
 rm -rf  %{octpkgdir}/doc
to get rid of the unnecessary stuff, and add

%doc doc/optim-mini-howto-2.pdf doc/development/interfaces.txt

> > Please add a '-v' flag in the Makefile, so that the commands used in the build
> > are displayed.
> 
> Sorry where do you want -v exactly?

Even though the make process clearly compiles something, the compiler flags are
not shown. According to the man page, you should add -v flag to the mkoctfile
commands:

       -v, --verbose
               Echo commands as they are executed.

> If I use octave_pkg_build, I get a build error:
> error: the following dependencies where unsatisfied:
>    optim needs miscellaneous >= 1.0.11
>  optim needs struct >= 1.0.9
> 
> even though octave-miscellaneous and octave-struct are installed. Seems there
> is a problem with the dependency detection.

Then please file a bug against octave. Maybe the -nodeps flag needs to be added
to the octave_pkg_build macro.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.