[Bug 639292] Review Request: erlang-etorrent - Erlang BitTorrent client and library

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 25 08:37:10 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639292

anish <apatil at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |apatil at redhat.com

Bug 639292 depends on bug 638909, which changed state.

Bug 638909 Summary: Review Request: erlang-gproc - Extended process registry for Erlang
https://bugzilla.redhat.com/show_bug.cgi?id=638909

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

--- Comment #3 from anish <apatil at redhat.com> 2011-08-25 04:37:08 EDT ---

Here's an unofficial review for F15,

+ rpmlint output

rpmlint output is not silent 
[makerpm at dhcp201-181 SRPMS]$ rpmlint erlang-etorrent-1.1.2-1.fc12.src.rpm 
erlang-etorrent.src: W: spelling-error %description -l en_US scalability ->
sociability, implacability, capability
erlang-etorrent.src: W: invalid-url Source0:
jlouis-etorrent-v1.1.2-0-g229f2de.tar.gz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


+ Package Naming Guidelines
    * Spec file name is erlang-etorrent.spec and srpm name is
erlang-etorrent-1.1.2-1.fc12.src.rpm which is okie 

+ Used global variables in the spec file which is good 

+ Sepc file is in American English 

+ License mentioned in spec file is "BSD" which looks okie 

+ Installed the erlang-etorrent-1.1.2-1.fc15.x86_64.rpm into the system
following files are getting updated onto the   system 
       /usr/sbin/etorrentctl
       /usr/lib64/erlang/lib/etorrent-1.1.2
       /etc/etorrent

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list