[Bug 728956] Review Request: php-virt-control - PHP-based virtual machine controller tool

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 25 15:02:14 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728956

--- Comment #12 from Michal Novotny <minovotn at redhat.com> 2011-08-25 11:02:14 EDT ---
(In reply to comment #11)
> Created attachment 519630 [details]
> php-libvirt-check.patch
> 
> This patch solves the x86_64 check_version issue.
> 
> I think most test which are available and which could run during rpm build
> should be run in %check.
> 
> Another small issue :
> mak check run test against the installed version, not against the build one.

Thanks for the patch Remi! I've applied it to the git tree now!

Thanks again!
Michal

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list