[Bug 708765] Review Request: Frogr - Flickr Remote Organizer for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708765

Gianluca Sforna <giallu at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #78 from Gianluca Sforna <giallu at gmail.com> 2011-08-25 11:08:31 EDT ---
Ok, here is the review:

- package named according to package naming guidelines
- spec filename matches %{name}
- package licensed with open source compatible license (GPLv3)
- license matches actual license
- license file included in %doc
- spec written in American english
- spec legible
- source matches upstream e6a86c71599561f41cfd7d71f56dcd9f  frogr-0.6.1.tar.xz
- successfully builds in mock for F15 x86_64
- macro usage is consistent
- package contains code
- no large documentation
- correctly installs a .desktop file

Just a couple comments.

The Source0 URL is not good for the 0.6.1 release (check it out running
"spectool -g frogr.spec"), you'll need to hardcode 0.6 instead of %{version} to
fix it.

Strictly speaking, since you install docs in /usr/share/gnome/help you should
either own that directory or require the packaging owning it (yelp), but I
found a thread in fedora-packaging where it seems it's ok to leave it this way.

Ideally, frogr could be improved to print the error returned by the GNOME API
when yelp is not available.

So, this package is APPROVED, but please be sure to fix the Source0 URL before
importing it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.