[Bug 732200] Review Request: Berusky2 - 3D sequel of Berusky

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732200

--- Comment #7 from Richard Shaw <hobbes1069 at gmail.com> 2011-08-26 10:56:11 EDT ---
Ok, here's my first pass:

1. You don't need BuildRoot:, %clean, or the rm -rf %{buildroot} in %install if
you're only planning on building for F14+

You also don't need the two "Requires:" lines since rpmbuild is pretty good at
figuring out dependencies.

What Volker was meaning by "-p" was the preserve timestamp option on "cp" and
"install". 

2. I could not get the package to build because it was failing to find some
headers. I had to add the following:

# Fix header references
sed -i "s/menu.h/Menu.h/g" src/kofola/Menu.cpp
sed -i "s/menu.h/Menu.h/g" src/kofola/game_main.cpp
sed -i "s/menu.h/Menu2.h/g" src/kofola/Menu2.cpp

I'm not sure how you got it to build without this. Perhaps you're not using gcc
4.6 and in previous versions this was only a warning?

3. There's an easier trick to getting the documentation installed to the right
directory. (Thanks to Hans for teaching me this one!) We don't need INSTALL
since we're providing a package.

Move the documentation back to the build directory in a temporary directory.
Then reference that directory in the %doc macro, e.g.:

# Move documentation so it can get installed to the right place.
mkdir _tmpdoc
mv %{buildroot}%{_usr}/doc/%{name}/* _tmpdoc/
rm -f _tmpdoc/INSTALL

Then in your %doc:

%doc _tmpdoc/*

4. This package has a manual requires for berusky2-data. From your sourceforge
link it appears that the data source is separate for a good reason? 

I noticed that it has a version of 0.4 while this has a version of 0.3. Are
they intended to revise separately?

If so we should probably cover the review request for the data package here as
well.


I would usually leave the updates to be made by the requester as it's a good
way to learn but there are so many changes I'll attach my updated spec file for
you to review.

Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.