[Bug 715498] Review Request: elmer-hutiter - Open Source Finite Element Software for Multiphysical Problems

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 26 20:53:18 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715498

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #3 from Volker Fröhlich <volker27 at gmx.at> 2011-08-26 16:53:16 EDT ---
Please adapt the BR syntax according to the new ruling:

http://fedoraproject.org/wiki/PackagingGuidelines#Requiring_Base_Package

Drop "-n %{name}".

Defattr is no longer necessary.

Probably be a bit more specific in the files section. Also label the
documentation as such.

Installing via install -p -m 0644 AUTHORS ChangeLog COPYING NEWS README -t
$RPM_BUILD_ROOT/%{_docdir}/hutiter/ and so on is wrong. Use the %doc macro.

Is it possible to build shared libs?

I'm not a hundred percent sure if the package is really GPLv2+. Do you have a
statement somewhere?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list