[Bug 732200] Review Request: Berusky2 - 3D sequel of Berusky

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732200

--- Comment #12 from Richard Shaw <hobbes1069 at gmail.com> 2011-08-26 17:08:19 EDT ---
Ok, preliminary review for berusky2-data:

1. Typical stuff:
BuildRoot, %clean, "rm -rf %{buildroot}" in %install and defattrib's can be
removed.

2. Changed macro "define" to "global" as it's preferred[1].

3. I fixed the Source: line to use the official sourceforge URL[1] but left the
URL: for you to update to whatever is most appropriate.

4. In this case since there's nothing to build, %build can be removed. rpmlint
will complain but we can ignore it.

5. I cleaned up the "mv" operation to a bit to improve readability.

6. If a package owns a directory and all items in it then you can just
reference the directory (without leading "/" I believe) and it will grab
everything. That simplifies your:
%dir %{_datadir}/%{game_name}
%{_datadir}/%{game_name}/*

to:
%{_datadir}/%{game_name}

I'll upload a new sepc but you should update the changelog and bump the
revision as I did not.

Richard

[1]
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
[2] http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.