[Bug 708711] Review Request: nomnom - The graphical video download tool

bugzilla at redhat.com bugzilla at redhat.com
Sat Aug 27 07:06:24 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708711

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

Bug 708711 depends on bug 708554, which changed state.

Bug 708554 Summary: Review Request: umph - Command line tool for parsing video links from Youtube feeds
https://bugzilla.redhat.com/show_bug.cgi?id=708554

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |MODIFIED
             Status|MODIFIED                    |ON_QA
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

--- Comment #8 from Volker Fröhlich <volker27 at gmx.at> 2011-08-27 03:06:23 EDT ---
License is GPLv3+, according to the headers.

Buildroot, clean section and the rm in the install section are only necessary,
when you plan to go for EPEL5 or older.

Defattr is no longer necessary.

Please handle the locales as described in
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files.

You won't need gettext though, but you'll have to append --with-qt to the
%find_lang call.

I recommend putting each BuildRequires and Requires on a separate line.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list