[Bug 733848] Review Request: octave-gsl - Octave bindings to the GNU Scientific Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=733848

Thomas Sailer <t.sailer at alumni.ethz.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.sailer at alumni.ethz.ch
         AssignedTo|nobody at fedoraproject.org    |t.sailer at alumni.ethz.ch

--- Comment #1 from Thomas Sailer <t.sailer at alumni.ethz.ch> 2011-08-27 17:11:51 EDT ---
Fedora review octave-gsl-1.0.8-1.fc15.src.rpm 2011-08-27

+ OK
! needs attention

+ rpmlint output
  The rpmlint warnings/errors listed above can be ignored and are normal
  for octave forge packages
+ Package is named according to Fedora Package Naming Guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora packaging guidelines
+ License meets guidelines and is acceptable to Fedora
  GPLv2+
+ License matches the actual package license
+ The package contains the license file
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm
  9f45ab71dc77b57646d6bfab5984cccd  srpm/gsl-1.0.8.tar.gz
  9f45ab71dc77b57646d6bfab5984cccd  upstream/gsl-1.0.8.tar.gz

+ Package scratch-builds
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8

APPROVED by sailer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.