[Bug 560787] Review Request: python-mtTkinter - A thread-safe version of Tkinter

bugzilla at redhat.com bugzilla at redhat.com
Sun Aug 28 11:34:42 UTC 2011 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=560787

--- Comment #16 from Haïkel Guémar <karlthered at gmail.com> 2011-08-28 07:34:31 EDT ---
My review took into consideration previous comments from Jason and Spot.
Licensing issues should have been cleared, and though not actively maintained
(it has no need to be), upstream maintainer still answers.

Package Review: python-mtTkinter (noarch)
=========================================

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Package is named according to the Package Naming Guidelines. [1]
[x]  Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x]  Spec file is legible and written in American English.
[x]  Spec uses macros instead of hard-coded directory names.
[x]  Package consistently uses macros.
[x]  Requires correct
[-]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines. [2]
[x]  Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of
%install.
[x]  Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[-]  The spec file handles locales properly.
[x]  Changelog in prescribed format.
[!]  Rpmlint output is silent.
$ rpmlint -iv python-mtTkinter-0.4-2.fc15.src.rpm 
python-mtTkinter.src: I: checking
python-mtTkinter.src: W: spelling-error %description -l en_US multithreaded ->
multicolored
The value of this tag appears to be misspelled. Please double-check.

python-mtTkinter.src: W: spelling-error %description -l en_US tkinter ->
interlink, inter
The value of this tag appears to be misspelled. Please double-check.

python-mtTkinter.src: W: spelling-error %description -l en_US NET's -> Net's,
NE's, PET's
The value of this tag appears to be misspelled. Please double-check.

python-mtTkinter.src: I: checking-url
http://tkinter.unpythonic.net/wiki/mtTkinter (timeout 10 seconds)
python-mtTkinter.src: I: checking-url
http://tkinter.unpythonic.net/attach/mtTkinter/attachments/mtTkinter-0.4.tar.gz
(timeout 10 seconds)
python-mtTkinter.src: W: invalid-url Source0:
http://tkinter.unpythonic.net/attach/mtTkinter/attachments/mtTkinter-0.4.tar.gz
HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 0 specfiles checked; 0 errors, 4 warnings.

$ rpmlint -iv
/home/haikel/rpmbuild/RPMS/noarch/python-mtTkinter-0.4-2.fc15.noarch.rpm 
python-mtTkinter.noarch: I: checking
python-mtTkinter.noarch: W: spelling-error %description -l en_US multithreaded
-> multicolored
The value of this tag appears to be misspelled. Please double-check.

python-mtTkinter.noarch: W: spelling-error %description -l en_US NET's ->
Net's, NE's, PET's
The value of this tag appears to be misspelled. Please double-check.

python-mtTkinter.noarch: I: checking-url
http://tkinter.unpythonic.net/wiki/mtTkinter (timeout 10 seconds)
python-mtTkinter.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/mtTkinter.py
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

1 packages and 0 specfiles checked; 1 errors, 2 warnings.

===> you should not install mtTkinter.py with executable bits set
Some python modules provide a __main__ entry point for testing purpose (for
instance, httplib.py from stdlib) but they should not be installed with a 0755
mask.

[x]  License field in the package spec file matches the actual license.
LGPLv3+
[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-]  License file installed when any subpackage combination is installed.
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[3,4]
[x]  Sources contain only permissible code or content.
[!]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
     sha1sum provided sources: 87be4bc80ac0bfa77ea07a91ff65c3ec9e6b94a2
     sha1sum upstream sources: 461bfe1d3e9cf5df12fb6edad3c332397b6d101a

     Though diff had shown me no difference, please use upstream sources
(they're definitively not the same, since upstream sources properly uncompress
inside a subdirectory)

[-]  Compiler flags are appropriate.
[-]  ldconfig called in %post and %postun if required.
[x]  Package must own all directories that it creates.
[x]  Package does not own files or directories owned by other packages.
[-]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[!]  Permissions on files are set properly.
fix the mtTkinter.py permissions as seen above
[x]  Each %files section contains %defattr.
[-]  No %config files under /usr.
[-]  %config files are marked noreplace or the reason is justified.
[-]  Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application. [5]
[-]  Package contains a valid .desktop file.
[x]  Package contains code, or permissable content.
[-]  Package contains a SysV-style init script if in need of one.
[x]  File names are valid UTF-8.
[-]  Large documentation files are in a -doc subpackage, if required.
[x]  Package uses nothing in %doc for runtime.
[x]  Package contains no bundled libraries.
[-]  Header files in -devel subpackage, if present.
[-]  Static libraries in -static subpackage, if present.
[-]  Package contains no static executables.
[-]  Package requires pkgconfig, if .pc files are present.
[-]  Development .so files in -devel subpackage, if present.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package does not contain any libtool archives (.la).
[-]  Useful -debuginfo package or justification otherwise.
[-]  Rpath absent or only used for internal libs.
[x]  Package does not generate any conflict.
[x]  Package successfully compiles and builds into binary rpms on at least one
supported architecture.
[-]  Package is not known to require ExcludeArch.
[x]  Package installs properly.
[x]  Package obeys FHS, except libexecdir and /usr/target.
[-]  Package meets the Packaging Guidelines. [6]

=== SUGGESTED ITEMS ===
[x]  Package functions as described.
[x]  Latest version is packaged.
[x]  Package does not include license text files separate from upstream.
[x]  If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[-]  Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]  SourceX is a working URL.
[-]  SourceX / PatchY prefixed with %{name}.
[x]  Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[-]  %check is present and all tests pass.
[-]  Usually, subpackages other than devel should require the base package
using a fully versioned dependency.
[x]  Reviewer should test that the package builds in mock.
tested local build mock for f16 and rawhide (x86_64)
[x]  Package should compile and build into binary rpms on all supported
architectures.
[x]  Dist tag is present.
[x]  Spec use %global instead of %define.
[-]  Scriptlets must be sane, if used.
[-]  The placement of pkgconfig(.pc) files are correct.
[-]  No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]  Packages should try to preserve timestamps of original installed files.
[-]  File based requires are sane.
[-]  Man pages included for all executables.
[-]  Uses parallel make.
[-]  Patches link to upstream bugs/comments/lists or are otherwise justified.

=== Issues ===
1. use upstream sources
2. install mtTkinter.py module with permissions set to 0644

=== Final Notes ===

As soon as the two issues above are fixed, i'll approve this package.

================
*** PENDING  ***
================

[1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines
[2] https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 
[3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines
[4] https://fedoraproject.org/wiki/Licensing:Main
[5] https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
[6] https://fedoraproject.org/wiki/Packaging:Guidelines

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list