[Bug 733053] Review Request: perl-Unicode-CheckUTF8 - Checks if scalar is valid UTF-8
bugzilla at redhat.com
bugzilla at redhat.com
Sun Aug 28 19:03:47 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=733053
Mario Blättermann <mariobl at freenet.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |mariobl at freenet.de
AssignedTo|nobody at fedoraproject.org |mariobl at freenet.de
Flag| |fedora-review+
--- Comment #1 from Mario Blättermann <mariobl at freenet.de> 2011-08-28 15:03:47 EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3307770
$ rpmlint -i -v *
perl-Unicode-CheckUTF8.i686: I: checking
perl-Unicode-CheckUTF8.i686: I: checking-url
http://search.cpan.org/dist/Unicode-String/ (timeout 10 seconds)
perl-Unicode-CheckUTF8.src: I: checking
perl-Unicode-CheckUTF8.src: I: checking-url
http://search.cpan.org/dist/Unicode-String/ (timeout 10 seconds)
perl-Unicode-CheckUTF8.src: E: unknown-key GPG#b56a8bac
The package was signed, but with an unknown key. See the rpm --import option
for more information.
perl-Unicode-CheckUTF8.src: I: checking-url
http://search.cpan.org/CPAN/authors/id/B/BR/BRADFITZ/Unicode-CheckUTF8-1.03.tar.gz
(timeout 10 seconds)
perl-Unicode-CheckUTF8.x86_64: I: checking
perl-Unicode-CheckUTF8.x86_64: I: checking-url
http://search.cpan.org/dist/Unicode-String/ (timeout 10 seconds)
perl-Unicode-CheckUTF8-debuginfo.i686: I: checking
perl-Unicode-CheckUTF8-debuginfo.i686: I: checking-url
http://search.cpan.org/dist/Unicode-String/ (timeout 10 seconds)
perl-Unicode-CheckUTF8-debuginfo.x86_64: I: checking
perl-Unicode-CheckUTF8-debuginfo.x86_64: I: checking-url
http://search.cpan.org/dist/Unicode-String/ (timeout 10 seconds)
/home/mariobl/Arbeitsfläche/perl-Unicode-CheckUTF8/perl-Unicode-CheckUTF8-1.03-2.fc17.src/perl-Unicode-CheckUTF8.spec:
I: checking-url
http://search.cpan.org/CPAN/authors/id/B/BR/BRADFITZ/Unicode-CheckUTF8-1.03.tar.gz
(timeout 10 seconds)
5 packages and 1 specfiles checked; 1 errors, 0 warnings.
The srpm has been signed, probably unintended... No further issues.
---------------------------------
key:
[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
UCD, GPL+ or Artistic
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *86e8e76883e4ef96820f893aab6ccdca perl-Unicode-CheckUTF8.spec
a483f665b2bc62d7737c209294e64e1e Unicode-CheckUTF8-1.03.tar.gz
a483f665b2bc62d7737c209294e64e1e Unicode-CheckUTF8-1.03.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
I assume the packager has tested it. Don't know how to test it on my
system.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[+] SHOULD: Your package should contain man pages for binaries/scripts.
----------------
PACKAGE APPROVED
----------------
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list