[Bug 733692] Review Request: python-yourls - simple python client to the YOURLS URL shortner

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 29 12:40:44 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=733692

--- Comment #2 from Jon Ciesla <limb at jcomserv.net> 2011-08-29 08:40:43 EDT ---
Good:

- rpmlint checks return:

Invalid license tag, is GPL2+, should be GPLv2+

- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Everything's good but the license tag.  I'm running a mock build o\to test BRs,
so that's pending as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list