[Bug 734275] Review Request: aqemu - A QT graphical interface to QEMU and KVM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=734275

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de> 2011-08-30 02:27:17 EDT ---
Here are some additional notes:

- The package currently fails to build because of the macros in the %changelog.
  Add a second percent sign to quote macros in comments or changelog entries,
  e.g. %%prep.

- Drop the explicit Requires fields. The dependency on qt and qt-x11 is
detected
  automatically.

- .desktop files must be installed or verified with desktop-file-install or
  desktop-file-validate, respectively. See
  https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

- Don't mix $RPM_BUILD_ROOT and %{buildroot}. Choose one variant and stick 
  with it.

- The doc files should go to %{_datadir}/doc/%{name}-%{version}. The easiest 
  way to achieve this here is 
  * to remove directory %{_datadir}/%{name}/doc in %install,
  * to drop %{_datadir}/%{name}/doc from %files, and
  * to add "%doc AUTHORS CHANGELOG COPYING README TODO" to the %files section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.