[Bug 734275] Review Request: aqemu - A QT graphical interface to QEMU and KVM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=734275

--- Comment #6 from Stephen Gordon <sgordon at redhat.com> 2011-08-30 06:17:40 EDT ---
Spec URL: http://sgordon.fedorapeople.org/repo/SOURCES/aqemu.spec
SRPM URL: http://sgordon.fedorapeople.org/repo/SRPMS/aqemu-0.8.2-3.fc15.src.rpm

(In reply to comment #4)
> Here are some additional notes:
> 
> - The package currently fails to build because of the macros in the %changelog.
>   Add a second percent sign to quote macros in comments or changelog entries,
>   e.g. %%prep.

This is a bit odd as it was still building for me on F15, but makes sense
nonetheless. Updated.

> - Drop the explicit Requires fields. The dependency on qt and qt-x11 is
> detected
>   automatically.

Removed.

> - .desktop files must be installed or verified with desktop-file-install or
>   desktop-file-validate, respectively. See
>   https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

Updated to use desktop-file-validate. 

> - Don't mix $RPM_BUILD_ROOT and %{buildroot}. Choose one variant and stick 
>   with it.

Updated.

> - The doc files should go to %{_datadir}/doc/%{name}-%{version}. The easiest 
>   way to achieve this here is 
>   * to remove directory %{_datadir}/%{name}/doc in %install,
>   * to drop %{_datadir}/%{name}/doc from %files, and
>   * to add "%doc AUTHORS CHANGELOG COPYING README TODO" to the %files section.

Updated. This however has resulted in rpmlint highlighting that the COPYING
file contains an out of date FSF address which I will have to take up with
upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.