[Bug 756856] Review Request: python-pyflag - Forensic and Log Analysis GUI

Fri Dec 2 15:37:16 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=756856

--- Comment #5 from Soumya Kanti Chakraborty <soumya at dgplug.org> 2011-12-02 10:37:15 EST ---
(In reply to comment #4)
> Builds now. :)
> 
> rpmlint:
> 
> python-pyflag.src: W: spelling-error %description -l en_US tcpdump -> dumpster
> The value of this tag appears to be misspelled. Please double-check.

I can maximum keep it is as tcp dump for rpmlint :)
> 
> python-pyflag.src: W: invalid-url Source0:
> http://sourceforge.net/projects/pyflag/files/pyflag/0.85/pyflag-0.85.tar.bz2
> <urlopen error [Errno -2] Name or service not known>
> The value should be a valid, public HTTP, HTTPS, or FTP URL.

Regarding the source I guess its only the source I downloaded it from(just
paste the link in the browser and you end up downloading the tarball) 

> 
> python-pyflag.x86_64: W: private-shared-object-provides
> /usr/lib64/python2.7/site-packages/pyflag/index.so.0.0.0 index.so.0()(64bit)
>  and several similar.

The problem with this warning is this requires pre scan filtering. But
according to
http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering this
filtering can only be done to packages having this below two factors - 

* Noarch packages
* Architecture specific packages with no binaries in $PATH (e.g. /bin, 
/usr/bin, /sbin, /sbin) or libexecdir and no system libs in libdir. This
includes all of the subpackages generated from the spec file.

The problem is pyflag doesn't fall under any of the categories of above two
packages, so please suggest me what to do (also to quote the upstream is
absolutely not responding state, I mark them as dead for queries)

> 
> Also, lots of 
> 
> python-pyflag.x86_64: E: incorrect-fsf-address
> /usr/lib/python2.7/site-packages/pyflag/FileFormats/PCAP.py

As I already mentioned I have several times mailed the developers, the mailing
list, pinged them in IRC but they have never responded. This error can only be
corrected buy the upstream which is dead and I don't feel patching each file is
a feasible option for a package maintainer. So again let me know your views.

> And then: 
> 
> python-pyflag.x86_64: W: manual-page-warning /usr/share/man/man1/pyflag.1.gz
> 28: warning: numeric expression expected (got `)')
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary ewfexport
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary ewfacquire
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary remote_server
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary pyflash
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary evtool
> Each executable in standard binary directories should have a man page.   
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary sgzip
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary conf.py
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary ewfverify
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary ewfinfo
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary iowrapper
> Each executable in standard binary directories should have a man page.   
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary pyflag_launch
> Each executable in standard binary directories should have a man page.
> 
All this are errors related to either man page or non availability of the man
page which again leads to getting into upstream, same problem ..need guidance.

> python-pyflag-devel.x86_64: E: description-line-too-long C The package
> pyflag-devel contains the static libraries needed for Pyflag Development
> Your description lines must not exceed 80 characters. If a line is exceeding
> this number, cut it to fit in two lines.

Will do this.

> python-pyflag-devel.x86_64: W: only-non-binary-in-usr-lib
> There are only non binary files in /usr/lib so they should be in /usr/share.

Should I move all files in devel to /usr/share ?

> python-pyflag-devel.x86_64: W: no-documentation
> The package contains no documentation (README, doc, etc). You have to include
> documentation files.

Nothing to add here as documents as if devel in installed by default the
original package will be installed and that has documentations.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.