[Bug 757156] Review Request: perl-Env-C - Get/Set/Unset Environment Variables on the C level

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=757156

--- Comment #4 from Willington Vega <wvega at wvega.com> 2011-12-03 09:12:38 EST ---
Hi Jan,

I agree, those spelling errors are not a problem and reporting the issue with
the directory ownership back to the cpanspec package is a good idea.

I've seen on other reviews that is good to provide the updated spec file and
srpm as a different one, with the modifications, an increased release number
and the corresponding Changelog documentation. It is also helpful when
comparing spec files to debug errors like the one I'm going to describe next:

The package no longer builds in mock from the SRPM:
mock SRPMS/perl-Env-C-0.08-1.fc15.src.rpm

The important part of the build.log file says:

+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl
Can't locate Test/More.pm in @INC (@INC contains: blib/lib blib/arch
/usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
/usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at test.pl
line 4.
BEGIN failed--compilation aborted at test.pl line 4.
make: *** [test_dynamic] Error 2
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.yd2GUq (%check)
    Bad exit status from /var/tmp/rpm-tmp.yd2GUq (%check)
Child returncode was: 1

The problem is your updated spec file no longer BuildRequires perl(Test::More).

Thank you for your quick update.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.