[Bug 750099] Review Request: airinv - C++ Simulated Airline Inventory Management System Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=750099

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review+

--- Comment #3 from Thomas Spura <tomspur at fedoraproject.org> 2011-12-04 08:36:17 EST ---
Review:

- name ok
- descriptions ok
- BR ok
- doc has own COPYING and doesn't R the main package - ok
- library correct installed
- ldconfig called
- no static lib
- %files ok
- license ok
  (headers are missing, but as you are part of upstream, you know you should
have some ;))
- check is there
- macros everywhere
- doc is noarch
- R pkgconfig ok as you are building for el*
- BR there
- defattr there
- sources match:
  ccd19f9a48abe5d506c43a28544d96f5  airinv-0.1.1.tar.bz2
- koji build worked:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=3561152
- $ rpmlint /home/tom/rpmbuild/RPMS/*/airinv*
/home/tom/rpmbuild/SRPMS/airinv-0.1.1-1.fc16.src.rpm
5 packages and 0 specfiles checked; 0 errors, 0 warnings.

NOTICE:
- It looks strange, that _datadir/airinv is owned by the devel package and not
by the main package... Usually the main package would own such a directory and
put application data in it. But as only the devel package puts files there: ok


NEEDSWORK:
- This is in the build log:
Warning: the PDF reference manual
(/home/tom/rpmbuild/BUILD/airinv-0.1.1/doc/latex/refman.pdf) has failed to
build. You can perform a simple re-build (make in the doc/latex sub-directory).

and the refman.pdf is indeed missing. Please check why it fails and fix.

_____________________________________________________________________________

As there is only a minor doc fix needed, this package is:
_____________________________________________________________________________

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.