[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=755890

--- Comment #16 from Mo Morsi <mmorsi at redhat.com> 2011-12-08 06:50:24 EST ---
(In reply to comment #15)
> Ack! Sorry I keep finding stuff :)
> 
> 1. There's no documentation in the main package. I would include a line like
> this, with our without the PDF depending on if it's relevant:
> 
> %files
> %doc CHANGELOG LICENSE README docs/paper.pdf
> ... rest of %files section ...
> 

Done

> 2. Do we need python2 if we're building with python3?
> 
> If not change your BuildRequires to:
> 
> %if 0%{?with_python3}
> BuildRequires:  python3-devel
> %else
> BuildRequires:  python2-devel
> %endif # if with_python3

I believe the original way is the correct way. At least every package I've seen
does not conditionalize the BR: python2-devel and it is this way in the
guidelines as well

http://fedoraproject.org/wiki/Packaging:Python

BTW also fixed the DEFAULT_SNAPFILE bug (this will be shipped in the first
release after this RPM gets into Fedora, though you can manually apply the fix
for now if you want)

https://github.com/movitto/snap/commit/7a53119b1d5bd048a4ddfbdf5bf9962f3d5699dc


New uploads:
New Spec: http://mo.morsi.org/files/rpms/snap.spec
New SRPM: http://mo.morsi.org/files/rpms/snap-0.5-6.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.