[Bug 760177] Review Request: knot - Authoritative DNS server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760177

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #3 from Volker Fröhlich <volker27 at gmx.at> 2011-12-08 20:06:58 EST ---
You're not a packager yet, as far as I can see. If I'm correct, you'll need a
sponsor:
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

* You can drop "-n %{name}-%{version}", because that's the default

* rm -rf %{buildroot}/* should not be necessary, except you're aiming for EPEL
5 (then you'd also needed the buildroot definition)

* The sharedstatedir can replace %{_var}/lib/

* You should preserve the timestamp on the service file

* Ldconfig is not necessary, as there are no libraries in this package

* Optflags are not honoured by the compiler

* Please be a bit more precise in the changelog

* You can use the name macro in Source0 and 1

* You haven't removed %doc from the man pages

* Include COPYING, AUTHORS, RELNOTES and KNOWN_ISSUES

* License is GPLv3+, not GPLv3

* Defining prefix, sysconfdir, etc. once should be enough (make/make install)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.