[Bug 758734] Review Request: fatrat-subtitlesearch - FatRat plugin enabling OpenSubtitles.org and Sublight.si integration

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 9 02:01:28 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=758734

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #1 from Volker Fröhlich <volker27 at gmx.at> 2011-12-08 21:01:27 EST ---
* Package doesn't build on F16

* "Beta" must be in release, not version:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

* Drop the version requirement on Qt, we don't have versions older than 4.5

* The files indicate GPLv2, not v2+

* You can use the name macro in Source0 and in the files section

* Please add a comment on what your patch does and why you're deleting _docdir

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list