[Bug 766083] Fedora 17 feature Derelict

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=766083

Matthieu Saulnier <casper.le.fantom at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |casper.le.fantom at gmail.com
         AssignedTo|nobody at fedoraproject.org    |casper.le.fantom at gmail.com
               Flag|                            |fedora-review?

--- Comment #2 from Matthieu Saulnier <casper.le.fantom at gmail.com> 2011-12-11 06:26:23 EST ---
Hello,
some remarks:

- you can remove %defattr section at the beginning of each %file section
  https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

- "Group:" spécification is useless too, so you can remove it

- If you plan to build this package for EPEL < 6, ignore following remarks:
  - you can remove %clean section
    https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

  - you can remove "rm -rf %{buildroot}" at the beginning of %install section

- I found a difference between the spec file in attachement of this review
  request and the spec file uploaded on your fedorapeople(that is the same as
  the spec file in the srpm)

$ diff derelict.spec derelict.spec.bak
22,23c22,24
< BuildRequires:  ldc, ldc-phobos-devel, ldc-druntime-devel
< Requires:       ldc-phobos-devel, ldc-druntime-devel
---
> BuildRequires:  ldc
> BuildRequires:  ldc-phobos
> Requires:       ldc-phobos

  Please update accordingly changelog section

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.