[Bug 758470] Review Request: vmmlib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=758470

--- Comment #1 from Jan Kaluža <jkaluza at redhat.com> 2011-12-13 03:24:46 EST ---
The package looks good to me and I haven't found any issue there. The only
thing is that non-working unit-test. I can't say if the test itself is broken
or there's really bug in vmmlib. The true is vmmlib throws an exception which
can be catched later. But what I would like to see is to at least contact
upstream and get its opinion on this. I'm not sure I want to accept library
when unit-test fails for unknown reason.

Could you ask upstream to clarify the situation please? They look active
according to commits, so it should not take a long time to get the response.

[YES] rpmplint is silent
[YES] Package meets naming guidelines.
[YES] Package meets packaging guidelines.
[YES] Spec file matches base package name.
[YES] License file is present, matching with spec file.
[YES] Licensing Guidelines are met.
[YES] Spec file is legible and in American English.
[YES] Sources match upstream.
[YES] Package builds OK.
[YES] BuildRequires are correct.
[YES] Package doesn't bundle copies of system libraries.
[YES] Package owns all the directories it creates.
[YES] Package has no duplicity in %files.
[YES] Permission on files are set properly.
[YES] Package is code or permissible content.
[YES] %doc files don't affect runtime.
[YES] Package doesn't own files/directories that other packages own.
[YES] All files are valid UTF-8.

Should items:
[YES] Package builds in mock.
[YES] Package uses sane scriptlets.
[NO] Package contains man pages.
[YES] Very simple functionality test passed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.