[Bug 767305] Review Request: litmus - WebDAV server compliance test suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=767305

Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #4 from Steve Traylen <steve.traylen at cern.ch> 2011-12-14 08:16:59 EST ---

So you presumably meant 

--with-neon=%{_prefix}
and not
--with-neon=${_prefix}

so I am reviewing after making that change.


 +:ok, =:needs attention, -:needs fixing

MUST Items:
[+] MUST: rpmlint must be run on every package.
$ rpmlint ./*.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
GPLv2
[+] MUST: The License field in the package spec file must match the actual
license.
Clear licensing.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
$ md5sum litmus-0.13.tar.gz ../SOURCES/litmus-0.13.tar.gz 
7c081e182214e771bc615232ef475b00  litmus-0.13.tar.gz
7c081e182214e771bc615232ef475b00  ../SOURCES/litmus-0.13.tar.gz

[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
See koji builds.
[+] SHOULD: The reviewer should test that the package functions as described.
litmus 
litmus: Usage: /usr/bin/litmus [OPTIONS] URL [USERNAME PASSWORD]

Options:
 -k, --keep-going        continue test
.... that's good enough

Comments 

1:
Your configure line currently expands to :

/configure --build=x86_64-unknown-linux-gnu --host=x86_64-unknown-linux-gnu
--target=x86_64-redhat-linux-gnu --program-prefix= --prefix=/usr
--exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc
--datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64
--libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib
--mandir=/usr/share/man --infodir=/usr/share/info --with-neon=

%{_prefix} and not ${_prefix}



2:
https://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries#Packages_with_Bundled_Libraries

The lib directory contains a load of bundled sources including some glibc ,
expat and neon.
It looks like you are not using them but proove this by adding a 
rm -rf lib
to your %prep.

Actually I tried this and it fails since the Makefile in lib/neon is still
needed. 
You need to be bit more creative by either 
a) 
rm -rf lib/*.c lib/*.h lib/expat lib/neon/*.c lib/neon/*.h

b)
rm -rf lib
and then patch the Makefile generation.

In principal (b) is better but (a) is perfectly fine and is what I would do.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.