[Bug 757851] Review Request: ark - Archive manager

bugzilla at redhat.com bugzilla at redhat.com
Thu Dec 15 10:06:47 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=757851

Radek Novacek <rnovacek at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |rnovacek at redhat.com
         AssignedTo|nobody at fedoraproject.org    |rnovacek at redhat.com
               Flag|                            |fedora-review?

--- Comment #2 from Radek Novacek <rnovacek at redhat.com> 2011-12-15 05:06:46 EST ---
Name: ok
License: not ok, batchextract.(h|cpp) have BSD license and are compiled to ark
binary in main package, so licence should be BSD and GPLv2+ (same as for -libs
subpackage)
Source: ok
BRs/Reqs: ok
Macros used consistently: ok
ldconfig: ok
Desktop file validations: ok
Locales: ok
Docs: COPYING should be installed
Devel: NA
Files: ok
Build: ok
rpmlint: no need to fix
ark.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
ark.src: W: spelling-error %description -l en_US rar -> arr, ear, tar
ark.src: W: spelling-error %description -l en_US lha -> la, ha, lea
ark.x86_64: E: script-without-shebang /usr/share/applications/kde4/ark.desktop
ark-libs.x86_64: W: obsolete-not-provided kdeutils-ark-libs
ark-libs.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 1 errors, 11 warnings.

Please, fix the license and docs and this package will be good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list