[Bug 768174] Review Request: srm-ifce - Storage Resources Manager client implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768174

Mohamed El Morabity <pikachu.2014 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pikachu.2014 at gmail.com

--- Comment #8 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2011-12-16 07:58:19 EST ---
The %{_isa} suffix on BuildRequires packages is useless, please remove it on
each BuildRequires.

globus-gssapi-gsi-devel is already required by globus-gss-assist-devel. As
well, gsoap-devel is required by CGSI-gSOAP-devel. So you can remove
globus-gssapi-gsi-devel and  gsoap-devel from the BuildRequires.

On your devel subpackage:
   Requires: srm-ifce >= %{version}-%{release}
No. You can't require a superior version of srm-ifce for your devel package,
especially in case of API breaks in the next versions.
See http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
to fix it.

%{_datadir}/doc/srm-access-library-for-lcg_util/ doesn't seem to me a canonic
place to install documentation files. If you don't want/can't fix the code to
put them elsewhere, you should remove them in %install and use the %doc macro
to install them in %{_docdir}/%{name}-%{version}/ automatically.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.