[Bug 768310] Review Request: gridftp-ifce - GridFTP abstraction layer for wlcg.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768310

Mohamed El Morabity <pikachu.2014 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pikachu.2014 at gmail.com

--- Comment #1 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2011-12-16 08:31:32 EST ---
What is the real version of your sources? I can't find in the SVN repo a tag
corresponding to the 2.99.99. Nothing in the commit logs too.
I suppose this package is a version 3 prerelease of gridftp-ice. So please
consider the guidelines concerning prerelease versionning:
  
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release

automake is already required by libtool, and globus-ftp-client-devel by
globus-gass-copy-devel. So you can remove automake and globus-ftp-client-devel
from the BuildRequires.

About the %{_isa} macro and the documentation installation, same remarks than
in https://bugzilla.redhat.com/show_bug.cgi?id=768174

You'd better use the %{configure} macro in %build instead of calling
explicitely the script ./configure. The macro already sets the «
--prefix=%{_prefix} » and « --libdir=%{_libdir} » options. By the way, you can
also remove the « --enable-debug » and « --enable-wall » options, since the
macro already sets the CFLAGS to the default ones expected by the Fedora
Project: these flags already contains the -g and -Wall options.
The --disable-static option doesn't seem to work since a static library is
build anyway. Unless you can fix it, you should remove this option to
configure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.