[Bug 768894] Review Request: haven - Next Generation Backup System

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 20 14:38:26 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768894

T.C. Hollingsworth <tchollingsworth at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tchollingsworth at gmail.com

--- Comment #2 from T.C. Hollingsworth <tchollingsworth at gmail.com> 2011-12-20 09:38:26 EST ---
(In reply to comment #1)
> haven.spec: W: invalid-url Source1: haven-icons-0.0.2.tar.gz
> haven.spec: W: invalid-url Source0: haven-0.0.2.tar.gz

If you can't provide the full URL to these sources in SourceN for some reason,
you need to add a comment indicating how to obtain them.  For more information,
see:
http://fedoraproject.org/wiki/Packaging:SourceURL

You used "haven-gtkgui" as the subpackage for the GUI application, but most
Fedora packages use subpackages like "haven-gtk".  Consider changing it to be
consistent with existing packages.

You call the "-full" subpackage the "Basic version" in the summary.  I think
you got that backwards.  ;-)

Also, consider briefly articulating the difference between the full and basic
versions in the %description, to assist users in deciding which one to install.
 (See "yum info vim-minimal vim-enhanced" for an example.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list