[Bug 756435] Review Request: pytorctl - Python bindings for controlling the Tor router

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=756435

T.C. Hollingsworth <tchollingsworth at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tchollingsworth at gmail.com

--- Comment #2 from T.C. Hollingsworth <tchollingsworth at gmail.com> 2011-12-20 10:15:19 EST ---
Why do you prevent RHEL5 from building this as noarch?  RHEL 5 handles noarch
packages just fine.  (It's noarch *subpackages* of arch-dependent packages that
are an issue.)

Please use "cp -p" to retain timestamp information from upstream.  

Also, consider doing something like "install -pm0755" to avoid having to chmod
everything post-copy.  (It's not necessary, but simpler.)

Finally, you don't need the definition for %{?python_sitearch} at the top,
since this package isn't arch-specific.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.