[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769096

Willington Vega <wvega at wvega.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wvega at wvega.com

--- Comment #1 from Willington Vega <wvega at wvega.com> 2011-12-20 13:44:13 EST ---
Hello Yader,

I would like to provide an informal review for this package.


rpmlint shows the following errors and warnings for the SRPM:

rpmlint SRPMS/gnome-shell-extension-windowoverlay-icons-3.0-1.fc16.src.rpm 
gnome-shell-extension-windowoverlay-icons.src: W: summary-ended-with-dot C
Easily discover which application to select by viewing the app icons in the
windows overview.
gnome-shell-extension-windowoverlay-icons.src: E: summary-too-long C Easily
discover which application to select by viewing the app icons in the windows
overview.
gnome-shell-extension-windowoverlay-icons.src: E: description-line-too-long C
This extension allow to view the icons over the application in the windows
overview.
gnome-shell-extension-windowoverlay-icons.src: E: description-line-too-long C
Useful to avoid confusion with the windows when you have a lot of them open on
the
1 packages and 0 specfiles checked; 3 errors, 1 warnings.

No errors or warnings for the SPEC file.


Using wget to download the sources from URL listed as Source0 doesn't return a
tar file with proper name. I think using a comment to describe how to generate
the tarball and using that tarball as Source is better [1]. I propose the
following changes:

# wget https://github.com/sustmi/gnome-shell-extensions-sustmi/tarball/%%{git}
-O %%{name}-%%{version}-%%{git}.tar.gz
Source0:                %%{name}-%%{version}-%%{git}.tar.gz

With the above changes it builds on mock with target fedora-15. A warning is
added because no URL is being used in Source0.


1. https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.